#11 ✓resolved
Shawn Sorichetti

Differences showing in Changes.app

Reported by Shawn Sorichetti | April 4th, 2008 @ 09:10 AM | in 0.9 (Euterpe)

I have git set up to use Changes.app as GIT_EXTERNAL_DIFF in my .profile. Whenever I switch between revisions in GitNub, a new Changes.app window opens displaying the diff.

Is it possible for GitNub to override the GIT_EXTERNAL_DIFF environment variable and display the difference between each commit?

Thank you

~Shawn

Comments and changes to this ticket

  • Justin Palmer

    Justin Palmer April 16th, 2008 @ 01:53 PM

    hmm, I don't see why I couldn't do this, but should I be doing this? If you explicitly set a diff viewer, wouldn't you want to use that diff viewer?

  • Justin Palmer

    Justin Palmer April 16th, 2008 @ 02:01 PM

    • State changed from “new” to “open”
  • Shawn Sorichetti

    Shawn Sorichetti April 16th, 2008 @ 03:03 PM

    While it does show the differences in Changes if Changes is already open. When you first start GitNub it calls Changes for every commit that appears in the list that's visible.

    This means if I have a screen showing 12 commits and a scroll bar, I have to close the Changes window, a new window opens, and repeat for the 11 remaining viewable commits. Then I'm able to scroll down and select the one I'm actually interested in looking at.

    I can see your point, that I've chosen to use an external viewer, the current way it's working isn't correct. What would be best I think, is a button to open in the external viewer. This would allow me to preview the commit, then view in the external viewer if I really want to.

    Another option would be to only open the external viewer on a selected commit. This would solve the 12 Changes window issue.

    ~Shawn

  • Justin Palmer

    Justin Palmer April 22nd, 2008 @ 11:42 AM

    • Milestone set to 0.9 (Euterpe)

    Ah. In that event, I think it might be best to steal the GIT_EXTERNAL_DIFF from Changes.

  • Justin Palmer

    Justin Palmer May 14th, 2008 @ 12:37 PM

    Do you mind testing this to see if it works as expected?

    You should be able to put this in ApplicationController (below the pwd line is fine):

    ENV['GIT_EXTERNAL_DIFF'] = nil
    

    Build and then run nub.

  • Shawn Sorichetti

    Shawn Sorichetti May 14th, 2008 @ 01:31 PM

    I added the line editing /Applications/GitNub.app/Contents/Resources/ApplicationCrontroller.rb and then executed nub.

    It worked as expected. I am able to see the differences within GitNub now, and there's no more loading of Changes.app repeatedly.

    I can now use GitNub again :-)

    Thank you

    ~Shawn

  • Justin Palmer

    Justin Palmer September 26th, 2008 @ 04:52 PM

    • State changed from “open” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

People watching this ticket

Referenced by

Pages